chore(fspy): cleanup unused code on Windows#37
Merged
branchseer merged 6 commits intomainfrom Nov 19, 2025
Merged
Conversation
branchseer
changed the title
Merged
fengmk2
approved these changes
Nov 19, 2025
Brooooooklyn
deleted the
11-19-test_fspy_flatten_accesse_modes_before_asserting
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TL;DR
Improved file access tracking for Windows process creation and fixed path access detection in tests.
What changed?
subprocesstest toread_in_subprocessand added a newread_programtest to verify program file access detectionassert_containsin test utilities to properly handle access mode comparisonCreateProcessAandCreateProcessWfunctionsstack_once.rsmodule and simplified process creation hooksNativeStrby removing the unused ANSI string support, as Windows paths are primarily handled as wide stringsHow to test?
Why make this change?
The previous implementation had issues with detecting program file access during process creation on Windows. This change improves the reliability of file access tracking by simplifying the hook implementation and removing unnecessary complexity. The tests now properly verify that the system correctly tracks file access when creating processes, which is essential for accurate dependency tracking.